Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.7.1 to 2.8.0 #2228

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop-rails from 2.7.1 to 2.8.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.8.0

New features

  • #291: Add new Rails/SquishedSQLHeredocs cop. (@mobilutz)
  • #52: Add new Rails/AfterCommitOverride cop. (@fatkodima)
  • #323: Add new Rails/OrderById cop. (@fatkodima)
  • #274: Add new Rails/WhereNot cop. (@fatkodima)
  • #311: Make Rails/HelperInstanceVariable aware of memoization. (@koic)
  • #332: Fix Rails/ReflectionClassName cop false negative when relation had a scope parameter. (@bubaflub)

Bug fixes

  • #315: Allow to use frozen scope for Rails/UniqueValidationWithoutIndex. (@krim)
  • #313: Fix Rails/ActiveRecordCallbacksOrder to preserve the original callback execution order. (@eugeneius)
  • #319: Fix a false positive for Rails/Inquiry when #inquiry's receiver is a variable. (@koic)
  • #327: Fix Rails/ContentTag autocorrect to handle html5 tag names with hyphens. (@jaredmoody)

Changes

  • #312: Mark Rails/MailerName as unsafe for auto-correct. (@eugeneius)
  • #294: Update Rails/ReversibleMigration to register offenses for remove_columns and remove_index. (@philcoggins)
  • #310: Add EnforcedStyle to Rails/PluckInWhere. By default, it does not register an offense if pluck method's receiver is a variable. (@koic)
  • #320: Mark Rails/UniqBeforePluck as unsafe auto-correction. (@kunitoo)
  • #324: Make Rails/IndexBy and Rails/IndexWith aware of to_h with block. (@eugeneius)
  • #341: Make Rails/WhereExists configurable to allow where(...).exists? to be the prefered style. (@dvandersluis)
Changelog

Sourced from rubocop-rails's changelog.

2.8.0 (2020-09-04)

New features

  • #291: Add new Rails/SquishedSQLHeredocs cop. ([@mobilutz][])
  • #52: Add new Rails/AfterCommitOverride cop. ([@fatkodima][])
  • #323: Add new Rails/OrderById cop. ([@fatkodima][])
  • #274: Add new Rails/WhereNot cop. ([@fatkodima][])
  • #311: Make Rails/HelperInstanceVariable aware of memoization. ([@koic][])
  • #332: Fix Rails/ReflectionClassName cop false negative when relation had a scope parameter. ([@bubaflub][])

Bug fixes

  • #315: Allow to use frozen scope for Rails/UniqueValidationWithoutIndex. ([@krim][])
  • #313: Fix Rails/ActiveRecordCallbacksOrder to preserve the original callback execution order. ([@eugeneius][])
  • #319: Fix a false positive for Rails/Inquiry when #inquiry's receiver is a variable. ([@koic][])
  • #327: Fix Rails/ContentTag autocorrect to handle html5 tag names with hyphens. ([@jaredmoody][])

Changes

  • #312: Mark Rails/MailerName as unsafe for auto-correct. ([@eugeneius][])
  • #294: Update Rails/ReversibleMigration to register offenses for remove_columns and remove_index. ([@philcoggins][])
  • #310: Add EnforcedStyle to Rails/PluckInWhere. By default, it does not register an offense if pluck method's receiver is a variable. ([@koic][])
  • #320: Mark Rails/UniqBeforePluck as unsafe auto-correction. ([@kunitoo][])
  • #324: Make Rails/IndexBy and Rails/IndexWith aware of to_h with block. ([@eugeneius][])
  • #341: Make Rails/WhereExists configurable to allow where(...).exists? to be the prefered style. ([@dvandersluis][])
Commits
  • ed6c0e5 Cut 2.8.0
  • 7fed287 Merge pull request #342 from dvandersluis/where-exists-enforced-style
  • 9e00fda [Fix #341] Add EnforcedStyle to Rails/WhereExists to allow where(...).exists?...
  • 820df97 Use new RuboCop::Cop::Registry APIs instead of deprecated APIs
  • 786cc67 Suppress RuboCop's offense
  • 630ccf0 Merge pull request #334 from bubaflub/fix_reflection_class_name_matching_scop...
  • 20cc151 [Fix #332] Fix false negative for Rails/ReflectionClassName
  • ef26793 Tweak the changelog
  • 9e2ff2c Merge pull request #291 from mobilutz/ll-squished-heredocs
  • d2e978c Add new Rails/SquishedHeredocs cop
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file ruby labels Sep 7, 2020
@chvp
Copy link
Member

chvp commented Sep 7, 2020

4 errors occurred:
An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting /data/home/charlotte/repos/dodona/dodona/app/models/provider/g_suite.rb:25:2.
An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting /data/home/charlotte/repos/dodona/dodona/app/models/provider/office365.rb:25:2.
An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting /data/home/charlotte/repos/dodona/dodona/app/models/provider/saml.rb:25:2.
An error occurred while Rails/UniqueValidationWithoutIndex cop was inspecting /data/home/charlotte/repos/dodona/dodona/app/models/provider/smartschool.rb:25:2.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop-hq/rubocop/issues

Mention the following information in the issue report:
0.90.0 (using Parser 2.7.1.4, rubocop-ast 0.3.0, running on ruby 2.6.6 x86_64-linux)

We should probably report this?

This is (one of) the offending line: https://github.com/dodona-edu/dodona/blob/develop/app/models/provider/g_suite.rb#L25

@chvp
Copy link
Member

chvp commented Sep 7, 2020

@bmesuere bmesuere closed this Sep 7, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-rails-2.8.0 branch September 7, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants